Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync microsoft/vscode-go@d53b1b3 #17

Closed
wants to merge 8 commits into from
Closed

Sync microsoft/vscode-go@d53b1b3 #17

wants to merge 8 commits into from

Conversation

hyangah
Copy link
Contributor

@hyangah hyangah commented Mar 20, 2020

Merge branch 'master' of https://github.com/microsoft/vscode-go@d53b1b3

  • 'master' of https://github.com/microsoft/vscode-go:
    goLanguageServer: set completion follow up command from middleware (microsoft#3084)
    Add stacktrace dump and better error messages on EXC_BAD_ACCESS panics (microsoft#2904)
    Address mismatch on path separators in debug config (microsoft#2010) (microsoft#3108)

Created by

git pull --no-ff --log upstream master

hyangah and others added 7 commits March 11, 2020 09:32
@hyangah
telemetry.ts: send telemetry only if aiKey is not an empty string(mic…
330f08c 
…rosoft#3091)
@darkvertex
bug_report.md: Fix "architecture" typo. (microsoft#3095)
5dc0357
@hyangah
Include the link to release note/package overview in the update promp…
6d1bf5c 
…t, and update gopls default version (microsoft#3041)
@quoctruong
Address mismatch on path separators in debug config (microsoft#2010) (m…
7da5077 
…icrosoft#3108)
@lggomez
Add stacktrace dump and better error messages on EXC_BAD_ACCESS panics (
00c318b 
microsoft#2904)
@hyangah
goLanguageServer: set completion follow up command from middleware (m…
d53b1b3 
…icrosoft#3084)
@hyangah
Merge branch 'master' of https://github.com/microsoft/vscode-go into …
2066d2c 
…sync

microsoft/vscode-go@d53b1b3

* 'master' of https://github.com/microsoft/vscode-go:
  goLanguageServer: set completion follow up command from middleware (microsoft#3084)
  Add stacktrace dump and better error messages on EXC_BAD_ACCESS panics (microsoft#2904)
  Address mismatch on path separators in debug config (microsoft#2010) (microsoft#3108)
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Mar 20, 2020
@hyangah hyangah added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Mar 20, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@hyangah
Copy link
Contributor Author

hyangah commented Mar 20, 2020

cla label override: this is a merge commit

@gopherbot
Copy link
Collaborator

This PR (HEAD: 2066d2c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/224240 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@hyangah
src/goLanguageServer: add missing import
3a8de3f 
import of ProvideCompletionItenSignature was removed by
 https://go-review.googlesource.com/c/vscode-go/+/222417
which is not yet merged in upstream.
It is needed by the upstream commit microsoft/vscode-go@d53b1b3.
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. and removed cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. labels Mar 20, 2020
@hyangah hyangah added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Mar 20, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@gopherbot
Copy link
Collaborator

This PR (HEAD: 3a8de3f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/224240 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@hyangah
Copy link
Contributor Author

hyangah commented Mar 20, 2020

cla:yes override: this is a merge commit + a commit 3a8de3f (authored by me) that fixes merge conflicts.

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/224240.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Rebecca Stambler:

Patch Set 2: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/224240.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 20, 2020
@hyangah
Sync microsoft/vscode-go@d53b1b3
25c7bf5 
Merge branch 'master' of https://github.com/microsoft/vscode-go@d53b1b3

* 'master' of https://github.com/microsoft/vscode-go:
  goLanguageServer: set completion follow up command from middleware (microsoft#3084)
  Add stacktrace dump and better error messages on EXC_BAD_ACCESS panics (microsoft#2904)
  Address mismatch on path separators in debug config (microsoft#2010) (microsoft#3108)

Created by

`git pull --no-ff --log upstream master`

Change-Id: Id38768f3ec1bd01fa81325978f51f314fc1c08cb
GitHub-Last-Rev: 3a8de3f
GitHub-Pull-Request: #17
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/224240
Reviewed-by: Rebecca Stambler <[email protected]>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/224240 has been merged.

@gopherbot gopherbot closed this Mar 20, 2020
@Kurt-Shiwz Kurt-Shiwz mentioned this pull request Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hyangah @googlebot @gopherbot @darkvertex @quoctruong @lggomez